Bug 219649

Summary: [iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout correctly upon exit
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
dbates: review+
Patch for landing none

Jer Noble
Reported 2020-12-08 12:17:29 PST
[iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout correctly upon exit
Attachments
Patch (1.69 KB, patch)
2020-12-08 12:19 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2020-12-08 13:51 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.39 KB, patch)
2020-12-08 15:23 PST, Jer Noble 		dbates: review+
DetailsFormatted DiffDiff
Patch for landing (4.39 KB, patch)
2021-01-13 16:22 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-12-08 12:17:56 PST
<rdar://problem/72053237>
Jer Noble
Comment 2 2020-12-08 12:19:46 PST
Created attachment 415662 [details] Patch
Jer Noble
Comment 3 2020-12-08 13:51:55 PST
Created attachment 415674 [details] Patch
Tim Horton
Comment 4 2020-12-08 15:09:02 PST
Comment on attachment 415674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415674&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:245 > +#if PLATFORM(IOS) It seems unlikely that you mean PLATFORM(IOS) here? Shouldn't this be all IOS_FAMILY? > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:115 > + BOOL _savedHasOverridenLayoutParameters; > + CGSize _savedMinimumLayoutSizeOverride; > + CGSize _savedMaximumUnobscuredSizeOverride; Slightly disconcerting that all the rest are initialized.
Jer Noble
Comment 5 2020-12-08 15:23:36 PST
Created attachment 415683 [details] Patch
Jer Noble
Comment 6 2020-12-08 15:24:09 PST
(In reply to Tim Horton from comment #4) > Comment on attachment 415674 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415674&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:245 > > +#if PLATFORM(IOS) > > It seems unlikely that you mean PLATFORM(IOS) here? Shouldn't this be all > IOS_FAMILY? Ugh. Yes, IOS_FAMILY> > > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:115 > > + BOOL _savedHasOverridenLayoutParameters; > > + CGSize _savedMinimumLayoutSizeOverride; > > + CGSize _savedMaximumUnobscuredSizeOverride; > > Slightly disconcerting that all the rest are initialized. Added initializers.
Daniel Bates
Comment 7 2020-12-21 22:58:19 PST
Comment on attachment 415683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415683&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:246 > +@property (nonatomic, readonly) BOOL _hasOverridenLayoutParameters; Ok as is. Consider overriding instead of overridden. If going to keep overridden then consider fixing spelling. > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:159 > + _savedMinimumLayoutSizeOverride = webView._minimumLayoutSizeOverride; Ok as is. Consider rename using overriding
Jer Noble
Comment 8 2021-01-13 16:22:45 PST
Created attachment 417578 [details] Patch for landing
Note You need to log in before you can comment on or make changes to this bug.