Bug 219648

Summary: [CMake] Determine when to use $<TARGET_OBJECTS> for executables
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch
mcatanzaro: review+, ews-feeder: commit-queue-
Patch none

Description Don Olmstead 2020-12-08 11:29:41 PST 
...
Comment 1 Don Olmstead 2020-12-08 11:30:41 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-12-08 12:15:27 PST 
Created attachment 415660 [details]
Patch
Comment 3 Michael Catanzaro 2020-12-09 07:20:40 PST 
Comment on attachment 415660 [details]
Patch

Did this break Windows EWS?
Comment 4 Don Olmstead 2020-12-10 12:40:13 PST 
Created attachment 415912 [details]
Patch
Comment 5 Don Olmstead 2020-12-10 12:47:11 PST 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 415660 [details]
> Patch
> 
> Did this break Windows EWS?

Seems more like a glitch since this only has effect on executables and DumpRenderTree was not migrated to use the _FRAMEWORKS.
Comment 6 Don Olmstead 2020-12-10 12:57:43 PST 
Comment on attachment 415912 [details]
Patch

The Win EWS is super behind so I'll just watch the bots and roll out if necessary.
Comment 7 EWS 2020-12-10 13:28:43 PST 
Committed r270652: <https://trac.webkit.org/changeset/270652>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415912 [details].