Bug 219638

Summary: Remove access to com.apple.audio.toolbox.reporting.service
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Description Per Arne Vollan 2020-12-08 04:03:55 PST
Remove access to com.apple.audio.toolbox.reporting.service for WebKit processes, since this is a logging service which is not needed for correctness.
Comment 1 Per Arne Vollan 2020-12-08 04:04:18 PST
<rdar://problem/71638615>
Comment 2 Per Arne Vollan 2020-12-08 04:07:33 PST
Created attachment 415628 [details]
Patch
Comment 3 Darin Adler 2020-12-08 11:45:33 PST
Comment on attachment 415628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415628&action=review

> Source/WebKit/ChangeLog:9
> +        Remove access to com.apple.audio.toolbox.reporting.service for WebKit processes, since this is a logging service which is not needed for correctness.

In cases like this, do we need to include a line in the sandbox profile that says "prohibit this but don't log it" to save the resources that will otherwise be used to report the sandbox exception?
Comment 4 Per Arne Vollan 2020-12-08 13:08:00 PST
(In reply to Darin Adler from comment #3)
> Comment on attachment 415628 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415628&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        Remove access to com.apple.audio.toolbox.reporting.service for WebKit processes, since this is a logging service which is not needed for correctness.
> 
> In cases like this, do we need to include a line in the sandbox profile that
> says "prohibit this but don't log it" to save the resources that will
> otherwise be used to report the sandbox exception?

That is a good point. I can add that.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-12-09 00:27:29 PST
Created attachment 415726 [details]
Patch
Comment 6 EWS 2020-12-09 00:59:11 PST
Committed r270575: <https://trac.webkit.org/changeset/270575>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415726 [details].