Bug 219616

Summary: [ESNext] op_put_private_name is wrong
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Caio Lima 2020-12-07 14:54:49 PST
...
Comment 1 Caio Lima 2020-12-07 14:57:00 PST
Created attachment 415590 [details]
Patch
Comment 2 Tadeu Zagallo 2020-12-07 15:09:47 PST
Comment on attachment 415590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415590&action=review

r=me with a small nit

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1796
> +    bqneq t3, t1, .opPutPrivateNameSlow

Should't this be a `bpneq`?
Comment 3 Caio Lima 2020-12-08 05:50:08 PST
Created attachment 415629 [details]
Patch
Comment 4 Caio Lima 2020-12-08 05:51:14 PST
Comment on attachment 415629 [details]
Patch

Thank you very much for the review!
Comment 5 EWS 2020-12-08 06:52:18 PST
Committed r270537: <https://trac.webkit.org/changeset/270537>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415629 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-08 06:53:14 PST
<rdar://problem/72091196>