Bug 219597

Summary:

[WPE] Smooth scrolling should be enabled by default when built

Product:

WebKit

Reporter:

Chris Lord <clord>

Component:

Scrolling

Assignee:

Chris Lord <clord>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

aperez, berto, cgarcia, darin, ews-watchlist, gustavo, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Lord 2020-12-07 03:27:14 PST

The GTK backend has settings that the WPE backend doesn't, so if you build with smooth scrolling enabled, there's no way to actually enable it on a WPE build. WPE builds should have smooth scrolling enabled if smooth scrolling is explicitly built, at least until we have an equivalent settings framework.

Comment 1 Chris Lord 2020-12-07 04:05:48 PST

Created attachment 415548 [details]
Patch

Comment 2 EWS Watchlist 2020-12-07 04:06:53 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Chris Lord 2020-12-07 04:07:19 PST

To clarify that first comment, I mean it has means to change those settings that WPE doesn't. It doesn't make sense to have settings that aren't built by default that also aren't enabled when explicitly built on WPE.

Comment 4 Chris Lord 2020-12-11 06:21:56 PST

This isn't correct, there is API to change this, it's just not accessible via minibrowser from the command-line like it is in GTK.