Bug 219576

Summary: [JSC] get / set for object literal and class should not be escaped
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ashvayka: review+

Yusuke Suzuki
Reported 2020-12-06 03:53:27 PST
[JSC] get / set for object literal and class should not be escaped
Attachments
Patch (9.58 KB, patch)
2020-12-06 03:54 PST, Yusuke Suzuki 		ashvayka: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-12-06 03:54:43 PST
Created attachment 415513 [details] Patch
Alexey Shvayka
Comment 2 2020-12-06 07:34:37 PST
Comment on attachment 415513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review Marvelous, r=me! > Source/JavaScriptCore/ChangeLog:8 > + "get" and "set" for getter and setter should not be escaped one. Perhaps it's worth to explain why not, in contrast to previous patch? Like: Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written. [1]: https://tc39.es/ecma262/#sec-method-definitions
Yusuke Suzuki
Comment 3 2020-12-06 12:27:11 PST
Comment on attachment 415513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + "get" and "set" for getter and setter should not be escaped one. > > Perhaps it's worth to explain why not, in contrast to previous patch? Like: > > Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written. > > [1]: https://tc39.es/ecma262/#sec-method-definitions That's very nice! I've added :D
Yusuke Suzuki
Comment 4 2020-12-06 12:42:12 PST
Committed r270487: <https://trac.webkit.org/changeset/270487>
Radar WebKit Bug Importer
Comment 5 2020-12-06 12:43:15 PST
<rdar://problem/72026319>
Note You need to log in before you can comment on or make changes to this bug.