| Summary: | Stop constructing unnecessary AudioBus in SincResampler | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-12-04 13:39:54 PST
Created attachment 415455 [details]
Patch
Comment on attachment 415455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415455&action=review > Source/WebCore/platform/audio/MultiChannelResampler.cpp:56 > + void provideInputForChannel(float* buffer, size_t framesToProcess, unsigned channelIndex) Surprised that this function can just return and do nothing, with no indication to the caller. But that’s not new. Comment on attachment 415455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415455&action=review >> Source/WebCore/platform/audio/MultiChannelResampler.cpp:56 >> + void provideInputForChannel(float* buffer, size_t framesToProcess, unsigned channelIndex) > > Surprised that this function can just return and do nothing, with no indication to the caller. But that’s not new. I actually does not in practice. You can see that there are assertions for all conditions where we early return. For some reason though, the person who wrote this code did both assertions and early return in release if the assertion would have failed. Comment on attachment 415455 [details] Patch Clearing flags on attachment: 415455 Committed r270460: <https://trac.webkit.org/changeset/270460> All reviewed patches have been landed. Closing bug. |