| Summary: | [iOS] Provide a context menu action to perform accessibility image extraction | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Platform | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, dino, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=219398 https://bugs.webkit.org/show_bug.cgi?id=221058 |
||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2020-12-03 18:53:56 PST
Created attachment 415375 [details]
Patch
Comment on attachment 415375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415375&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:76 > +- (void)actionSheetAssistant:(WKActionSheetAssistant *)assistant imageExtraction:(UIImage *)image; Nit - this is a bit of a funny name for a delegate method. Usually, it's either a noun (if the delegate returns something), like `- (Foo *)instance:fooForPurpose:`, or it's a verb, like `- (void)instance:doFoo:`. Maybe this should be something along the lines of `-actionSheetAssistant:extractImage:` or `-actionSheetAssistant:handleImageExtraction:`. Created attachment 415426 [details]
Patch
Committed r270436: <https://trac.webkit.org/changeset/270436> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415426 [details]. |