| Summary: | [webkitscmpy] Incorrect identifier on remote SVN branches | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, slewis, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-12-03 14:44:21 PST
Not sure there is much we could do in testing to prevent this, other than having a set of tests that compare the results on an actual checkout with those of an actual remote, which is something we have traditionally tried to avoid. Created attachment 415352 [details]
Patch
From a Slack conversation explaining the motivation: The request being modified here was reverse engineered from inspecting packets sent by the svn binary. I had stripped a few pieces out that I thought we didn't need so we had less data being transferred, but it appears I stripped out a piece we did need (that is, the "<S:path></S:path>" bit) Created attachment 415355 [details]
Patch for landing
Committed r270412: <https://trac.webkit.org/changeset/270412> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415355 [details]. |