Bug 219497

Summary: Refactor macros for low power mode code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ews-watchlist, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Chris Dumez 2020-12-03 10:42:18 PST 
Refactor macros for low power mode code.
Comment 1 Chris Dumez 2020-12-03 10:44:56 PST 
Created attachment 415311 [details]
Patch
Comment 2 Chris Dumez 2020-12-03 10:55:21 PST 
Created attachment 415313 [details]
Patch
Comment 3 Chris Dumez 2020-12-03 11:33:08 PST 
Created attachment 415315 [details]
Patch
Comment 4 Chris Dumez 2020-12-03 11:43:45 PST 
Created attachment 415316 [details]
Patch
Comment 5 Geoffrey Garen 2020-12-03 12:49:04 PST 
Comment on attachment 415316 [details]
Patch

r=me
Comment 6 EWS 2020-12-03 13:15:19 PST 
Committed r270406: <https://trac.webkit.org/changeset/270406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415316 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-03 13:16:21 PST 
<rdar://problem/71949711>
Comment 8 Sam Weinig 2020-12-19 11:34:20 PST 
Comment on attachment 415316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415316&action=review

> Source/WebCore/platform/cocoa/LowPowerModeNotifier.mm:104
> +#endif // PLATFORM(APPLE_LOW_POWER_MODE_SUPPORT)

This should say HAVE(APPLE_LOW_POWER_MODE_SUPPORT).