Bug 219466

Summary: MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cdumez: review+, cdumez: commit-queue-
Patch for landing
none
Patch none

Description Jer Noble 2020-12-02 17:06:04 PST 
MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Comment 1 Jer Noble 2020-12-02 17:11:50 PST 
<rdar://problem/71566601>
Comment 2 Jer Noble 2020-12-02 17:12:13 PST 
Created attachment 415265 [details]
Patch
Comment 3 Chris Dumez 2020-12-02 17:14:06 PST 
Comment on attachment 415265 [details]
Patch

r=me
Comment 4 Chris Dumez 2020-12-02 17:15:05 PST 
Comment on attachment 415265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147
> +    sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>();

makeUnique<> is the new way iirc.
Comment 5 Chris Dumez 2020-12-02 17:15:10 PST 
Comment on attachment 415265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147
> +    sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>();

makeUnique<> is the new way iirc.
Comment 6 Jer Noble 2020-12-02 17:27:19 PST 
Created attachment 415266 [details]
Patch for landing
Comment 7 Chris Dumez 2020-12-03 08:32:35 PST 
Created attachment 415302 [details]
Patch
Comment 8 EWS 2020-12-03 09:16:08 PST 
Committed r270394: <https://trac.webkit.org/changeset/270394>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415302 [details].