Bug 219453

Summary: [iOS] Add a feature flag to stop leaking an XPC boost message to XPC services
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ews-watchlist, ggaren, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220883
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-12-02 13:21:02 PST 
Stop leaking an XPC boost message to XPC services on builds where RunningBoard is able to give the right priorities to our XPC services based on the type of RunningBoard assertion is being held. There is no behavior change for the Network/WebContent processes since those were blocklisted in RunningBoard (Turning on the RB_full_manage_WK_jetsam feature flag gives us the default RunningBoard behavior without blocklisting). However, this allows the new GPUProcess to move to IDLE jetsam band when homing out of MobileSafari, which makes the GPUProcess eligible for the freezer. Previously, the leaked boost message would keep the GPUProcess in a higher jetsam band.
Comment 1 Chris Dumez 2020-12-02 13:21:27 PST 
<rdar://47402853>
Comment 2 Chris Dumez 2020-12-02 13:28:37 PST 
Created attachment 415250 [details]
Patch
Comment 3 Geoffrey Garen 2020-12-02 13:47:55 PST 
Comment on attachment 415250 [details]
Patch

r=me
Comment 4 EWS 2020-12-08 09:40:00 PST 
Committed r270542: <https://trac.webkit.org/changeset/270542>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415250 [details].
Comment 5 Chris Dumez 2020-12-10 10:06:45 PST 
Reverted r270542 for reason:

Seems to have regressed perf benchmarks

Committed r270632: <https://trac.webkit.org/changeset/270632>
Comment 6 Chris Dumez 2020-12-18 09:24:20 PST 
Committed r270969: <https://trac.webkit.org/changeset/270969>
Comment 7 Chris Dumez 2020-12-20 15:16:22 PST 
Reverted r270969 for reason:

Regressed MotionMark with GPUProcess enabled

Committed r271017: <https://trac.webkit.org/changeset/271017>
Comment 8 Chris Dumez 2021-01-05 17:00:28 PST 
Created attachment 417056 [details]
Patch
Comment 9 EWS 2021-01-05 19:25:14 PST 
Committed r271189: <https://trac.webkit.org/changeset/271189>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417056 [details].