| Summary: | Simplify some callsites of WheelEventTestMonitor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2020-12-01 17:09:09 PST
Created attachment 415179 [details]
Patch
Created attachment 415186 [details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=415179&action=review > Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:161 > + auto makeDeferrer = [&]() -> WheelEventTestMonitorCompletionDeferrer { Consider just using a local and moving it because this function is unconditionally invoked (so not avoiding computing it sometimes) and its body is branchless. Oh, the repeated reinterpret_casts i now see. Could extract this lambda into a real function that does the cast. > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:101 > + auto makeDeferrer = [&]() -> WheelEventTestMonitorCompletionDeferrer { Same as above. |