| Summary: | [Media in GPU Process][MSE] Implement basic video playback | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||||||||||||||||
| Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | Other | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=254324 | ||||||||||||||||||||||||
| Bug Depends on: | 219332 | ||||||||||||||||||||||||
| Bug Blocks: | 219658 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Peng Liu
2020-12-01 09:52:53 PST
Created attachment 415487 [details]
WIP patch
Created attachment 415493 [details]
WIP - fix layout test crashes
Created attachment 415504 [details]
WIP - fix issues on youtube
Created attachment 415506 [details]
WIP - update MockSourceBufferPrivate to fix layout test failures
Created attachment 415512 [details]
WIP - fix build failures on GTK/WPE and layout test failures
Created attachment 415531 [details]
Patch
Comment on attachment 415531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415531&action=review > Source/WebCore/ChangeLog:73 > + `SourceBufferPrivate` can figure the values of `hasAudio` and `hasVideo` because it s/figure/figure out/g Had a discussion with Jer. The condition variable usage in the source buffer parser seems fragile (and unnecessary). I will upload a new patch. Created attachment 415699 [details]
Update the patch based on Jer's comment
Created attachment 415705 [details]
Patch
Created attachment 415785 [details]
Update the patch based on a discussion with Jer
Created attachment 415810 [details]
Patch
Comment on attachment 415810 [details]
Patch
Fix a layout test failure on WK1.
Committed r270612: <https://trac.webkit.org/changeset/270612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415810 [details]. |