Bug 219377

Summary: [iOS] GPUProcess.CrashWhilePlayingVideo is flaky
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, Hironori.Fujii, ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219719
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-11-30 16:01:35 PST 
GPUProcess.CrashWhilePlayingVideo is flaky on iOS:
- https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo&platform=ios

---
    TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo
        2020-11-30 11:06:23.829 TestWebKitAPI[43951:111228852] *** Warning: <AVPlayerViewController: 0x7f975f84c000> is trying to enter full screen, but is not in its view's window's view controller hierarchy. This results in undefined behavior.
        
        /Volumes/Data/slave/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:282
        Value of: [webView _isPlayingAudio]
          Actual: false
        Expected: true
---

It seems that in some cases, video does resume playing but audio does not.
Comment 1 Radar WebKit Bug Importer 2020-12-01 11:19:47 PST 
<rdar://problem/71859117>
Comment 2 Ryan Haddad 2020-12-01 11:21:40 PST 
It looks like the first instance of this failure was on 11/20 at r270137, though that commit doesn't seem related at all, so it must have been something near that.
Comment 3 Ryan Haddad 2020-12-01 11:22:39 PST 
I reverted https://trac.webkit.org/changeset/270132/webkit in https://trac.webkit.org/changeset/270311 because it caused flakiness in an API test on macOS, perhaps that could be related.
Comment 4 Chris Dumez 2020-12-01 12:24:41 PST 
Created attachment 415153 [details]
Patch
Comment 5 EWS 2020-12-01 14:23:32 PST 
Committed r270328: <https://trac.webkit.org/changeset/270328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415153 [details].