Bug 219361

Summary:

Allow blob URLs with fragments

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Alex Christensen 2020-11-30 11:03:38 PST

Allow blob URLs with fragments

Comment 1 Alex Christensen 2020-11-30 11:05:54 PST

Created attachment 415035 [details]
Patch

Comment 2 Alex Christensen 2020-11-30 12:31:03 PST

Created attachment 415042 [details]
Patch

Comment 3 EWS 2020-11-30 15:15:33 PST

Committed r270269: <https://trac.webkit.org/changeset/270269>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415042 [details].

Comment 4 Radar WebKit Bug Importer 2020-11-30 15:16:25 PST

<rdar://problem/71825595>

Comment 5 Darin Adler 2020-11-30 15:17:21 PST

Comment on attachment 415042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415042&action=review

> Source/WebCore/platform/network/BlobRegistryImpl.cpp:228
> +    if (url.hasFragmentIdentifier())
> +        return m_blobs.get(url.stringWithoutFragmentIdentifier().toStringWithoutCopying());
>      return m_blobs.get(url.string());

We should consider adding a version of toStringWithoutCopying that takes a WTF::String that is used if it happens to exactly match. Then we would not need an if statement, and could retain the "no string allocation/deallocation" optimization.