Bug 219358

Summary:

[LFC] Move PositioningContext into its own file

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Layout and Rendering

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bfulgham, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	simon.fraser: review-

Description Don Olmstead 2020-11-30 08:40:02 PST

https://trac.webkit.org/changeset/270224/webkit broke the non-unified build because the BuildingState struct was defined in a cpp file. It references PositioningContext which is a class defined in that same file. Move it out into its own set of files.

Comment 1 Don Olmstead 2020-11-30 08:41:43 PST

Created attachment 415027 [details]
WIP Patch

Comment 2 Simon Fraser (smfr) 2020-11-30 10:40:26 PST

Comment on attachment 415027 [details]
WIP Patch

Just need a TreeBuilder::~TreeBuilder() = default in the cpp file.

Comment 3 Simon Fraser (smfr) 2020-11-30 10:45:33 PST

Fixed more simply in r270251.