Bug 219345

Summary:

Move code from AxisScrollSnapOffsets to ScrollSnapOffsetsInfo

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

CSS

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, changseok, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jamesr, kondapallykalyan, luiz, pdr, ryuan.choi, sergio, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

145099, 219273

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Martin Robinson 2020-11-30 03:05:51 PST

The API exposed by AxisScrollSnapOffsets is written with a one-dimensional set of scroll snap offsets in mind. Moving this code to ScrollSnapOffsetsInfo is the first step toward rewriting the API to deal with ScrollSnapOffsetsInfo, which abstracts away the implementation details of scroll snap offsets.

Comment 1 Martin Robinson 2020-11-30 03:15:35 PST

Created attachment 415011 [details]
Patch

Comment 2 Martin Robinson 2020-11-30 03:30:37 PST

Created attachment 415013 [details]
Patch

Comment 3 Daniel Bates 2020-12-02 19:34:56 PST

Comment on attachment 415013 [details]
Patch

This patch looks good. I see a lot of opportunities to modernize the moved code and use constexpr, range for-loops, etc etc. I think I've seen different code styling for templates in other code.

Comment 4 Martin Robinson 2020-12-03 01:38:34 PST

Thanks very much for the review. I would definitely like to continue improving this code.

Comment 5 EWS 2020-12-03 01:51:05 PST

Committed r270390: <https://trac.webkit.org/changeset/270390>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415013 [details].

Comment 6 Radar WebKit Bug Importer 2020-12-03 01:52:17 PST

<rdar://problem/71929518>