| Summary: | [ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Windows without Cygwin | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
| Component: | ANGLE | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, dino, ews-watchlist, graouts, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, krollin, ryuan.choi, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Fujii Hironori
2020-11-26 20:33:05 PST
Created attachment 414913 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 414913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review Looks fine with one piece of feedback on the copyright. r+ > Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3 > +# Copyright (C) 2020 Sony Interactive Entertainment Inc. I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)? Comment on attachment 414913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review Thank you for the review. >> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3 >> +# Copyright (C) 2020 Sony Interactive Entertainment Inc. > > I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)? Ok, I'll remove it. Created attachment 414972 [details]
Patch for landing
Committed r270212: <https://trac.webkit.org/changeset/270212> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414972 [details]. |