| Summary: | Support KHR_parallel_shader_compile | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
James Darpinian
2020-11-23 17:08:20 PST
Created attachment 414816 [details]
Patch
Comment on attachment 414816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414816&action=review Looks good to me > Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36 > + virtual ~KHRParallelShaderCompile(); Nit: maybe the virtual here could be removed and override/final added? Comment on attachment 414816 [details]
Patch
Looks good to me modulo Kimmo's feedback. r+
Created attachment 414855 [details]
Patch
Comment on attachment 414855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414855&action=review Good to see the conformance test and associated fixes. One minor comment about Kimmo's previous review. r+ > Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36 > + virtual ~KHRParallelShaderCompile(); Kimmo had a comment about marking this final in the last patch set. Created attachment 414856 [details]
Patch
Comment on attachment 414816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414816&action=review Thanks, I updated the patch with a test and a behavior change for the context loss case. The test and spec clarification are also upstream here: https://github.com/KhronosGroup/WebGL/pull/3188 >> Source/WebCore/html/canvas/KHRParallelShaderCompile.h:36 >> + virtual ~KHRParallelShaderCompile(); > > Nit: maybe the virtual here could be removed and override/final added? Done. Created attachment 414857 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 414857 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 415036 [details]
Patch
Committed r270257: <https://trac.webkit.org/changeset/270257> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415036 [details]. |