| Summary: | Introduce new display list meta commands in preparation for webkit.org/b/219091 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Layout and Rendering | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, ggaren, rniwa, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 219091 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2020-11-23 11:22:24 PST
Created attachment 414811 [details]
Patch
Comment on attachment 414811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review > Source/WebCore/ChangeLog:18 > + `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items; Why not just MetaCommandEnd. OfDisplayList seems redundant. Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future. > Source/WebCore/ChangeLog:24 > + by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item. Change we should rename this to MetaCommandChangeItemBuffer to be consistent although this is really more like MetaCommandContinueInNewItemBuffer. Comment on attachment 414811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review >> Source/WebCore/ChangeLog:18 >> + `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items; > > Why not just MetaCommandEnd. OfDisplayList seems redundant. > Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future. `MetaCommandEnd` sounds good to me — renamed to that. >> Source/WebCore/ChangeLog:24 >> + by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item. > > Change we should rename this to MetaCommandChangeItemBuffer to be consistent > although this is really more like MetaCommandContinueInNewItemBuffer. Makes sense — I'll rename it to `MetaCommandChangeItemBuffer` in this patch for consistency with `MetaCommandChangeDestinationImageBuffer`. Created attachment 414848 [details]
Patch
Created attachment 414849 [details]
Patch
Committed r270203: <https://trac.webkit.org/changeset/270203> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414849 [details]. |