| Summary: | AXIsolatedTree::m_axObjectCache should not be accessed on the secondary AX thread. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-11-20 13:59:59 PST
Created attachment 414727 [details]
Patch
Comment on attachment 414727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414727&action=review seems like a good change overall. only comment is that m_usingAXThread is not immediately clear for it's purpose based on the name. Does it mean that this Tree can use the AX thread, or it is on the AX thread? Is there a more clear name available? > Source/WebCore/ChangeLog:10 > + methods. this problem is fixed with this change by adding the member this problem > This problem Created attachment 414791 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 414727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414727&action=review > > seems like a good change overall. only comment is that m_usingAXThread is > not immediately clear for it's purpose based on the name. > Does it mean that this Tree can use the AX thread, or it is on the AX > thread? Is there a more clear name available? Renamed it to m_usedOnAXThread. > > > Source/WebCore/ChangeLog:10 > > + methods. this problem is fixed with this change by adding the member > > this problem > This problem Fixed. Thanks! Committed r270238: <https://trac.webkit.org/changeset/270238> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414791 [details]. |