Bug 219222

Summary: Fix non-unified build problem in CSSPropertyParserHelpers.cpp along with a little refactoring
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, clord, don.olmstead, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, sam, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2020-11-20 13:40:45 PST
Fix non-unified build problem in CSSPropertyParserHelpers.cpp along with a little refactoring
Attachments
Patch (8.82 KB, patch)
2020-11-20 13:44 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (8.77 KB, patch)
2020-11-20 13:53 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-11-20 13:44:30 PST
Created attachment 414713 [details] Patch
Darin Adler
Comment 2 2020-11-20 13:46:03 PST
Comment on attachment 414713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414713&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:54 > +static inline bool isCSSWideKeyword(const CSSValueID& id) This probably should just take CSSValueID rather than const&.
Darin Adler
Comment 3 2020-11-20 13:53:31 PST
Created attachment 414716 [details] Patch
EWS
Comment 4 2020-11-26 15:59:59 PST
Committed r270167: <https://trac.webkit.org/changeset/270167> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414716 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-26 16:00:59 PST
<rdar://problem/71754694>
Note You need to log in before you can comment on or make changes to this bug.