| Summary: | [LFC][Integration] Add contentOffset and contentWidth to Line | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2020-11-20 13:06:32 PST
Created attachment 414709 [details]
Patch
Created attachment 414719 [details]
Patch
Created attachment 414738 [details]
Patch
Created attachment 414739 [details]
Patch
Comment on attachment 414739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414739&action=review > Source/WebCore/layout/integration/LayoutIntegrationLine.h:53 > + , m_contentLeftOffset(contentLeftOffset) > + , m_contentWidth(contentWidth) Could the client just do content.runs[line.firstRunIndex()].rect().x() etc to get the same numbers? I guess having a redundant copy here doesn't hurt. Committed r270143: <https://trac.webkit.org/changeset/270143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414739 [details]. |