Bug 219207

Summary: Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, andersca, ews-watchlist, mifenton, richard_robinson2, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Sam Weinig
Reported 2020-11-20 09:15:08 PST
Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet
Attachments
Patch (2.29 KB, patch)
2020-11-20 09:17 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2020-11-20 10:36 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-11-20 09:17:08 PST
Created attachment 414689 [details] Patch
Anders Carlsson
Comment 2 2020-11-20 10:02:34 PST
Comment on attachment 414689 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414689&action=review > Source/WebCore/page/Settings.yaml:97 > + default: static_cast<DataDetectorType>(0) Not sure how this is turned into C++ but I wonder if it's possible to make it be { } ?
Sam Weinig
Comment 3 2020-11-20 10:33:42 PST
(In reply to Anders Carlsson from comment #2) > Comment on attachment 414689 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414689&action=review > > > Source/WebCore/page/Settings.yaml:97 > > + default: static_cast<DataDetectorType>(0) > > Not sure how this is turned into C++ but I wonder if it's possible to make > it be { } ? Hm, not sure. Will experiment with that.
Sam Weinig
Comment 4 2020-11-20 10:34:49 PST
Well, oops, looks like this breaks Debug tests due to an assert in OptionSet (which makes sense). Maybe { } will fair better.
Sam Weinig
Comment 5 2020-11-20 10:36:19 PST
Created attachment 414696 [details] Patch
Radar WebKit Bug Importer
Comment 6 2020-11-27 09:16:13 PST
<rdar://problem/71766018>
Ahmad Saleem
Comment 7 2024-07-22 05:08:46 PDT
@Ryan - you landed this: https://github.com/WebKit/WebKit/commit/8cf368ed3d211063f591761aaa24bf3d5e4deda3 After above, is this required? Or we can do further clean-up?
Ryan Reno
Comment 8 2024-07-22 08:46:27 PDT
@Ahmad That patch was written by Richard Robinson.
Note You need to log in before you can comment on or make changes to this bug.