Bug 219198
| Summary: | [GTK] [WPE] Add entries on the bots' /etc/hosts file for testing purpose | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cgarcia, jfernandez, mcatanzaro, pgriffis, pnormand |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 219257 | ||
| Bug Blocks: | 127676 | ||
Frédéric Wang (:fredw)
This can be a preliminary step for bug 127676.
It would also allow to rewrite our GTK API test for WebKitInsecureContentEvent without relying on "localhost" and "127.0.0.1" (which are supposed not to be treated as mixed content, see bug 171934).
Unfortunately Philippe mentioned that /etc/hosts in the flatpak sandbox is readonly.
Opening this to track the issue and discuss ideas on how to address it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Suggestion: you can write a GResolver that wraps the default GResolver and just specially resolves some extra host. Compile it into a shared object and have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it. Then you won't wind up with a test that breaks when not run on a specially-configured bot.
Michael Catanzaro
(In reply to Michael Catanzaro from comment #1)
> Suggestion: you can write a GResolver that wraps the default GResolver and
> just specially resolves some extra host. Compile it into a shared object and
> have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it.
> Then you won't wind up with a test that breaks when not run on a
> specially-configured bot.
Yeah this seems like a much better approach. It's not *too* complicated, and otherwise the affected tests will never pass when not run on bots. Surely we don't want to tell devs to edit their /etc/hosts.
Patrick Griffis
Fixed by bug 243428. It now exposes a generic way to add domains for testing.