Bug 219171

Summary: Turn on ENABLE_WEBXR for Cocoa
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebXRAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, benjamin, cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ada Chan
Reported 2020-11-19 11:24:15 PST
Turn on ENABLE_WEBXR for Cocoa rdar://71524773
Attachments
Patch (34.39 KB, patch)
2020-11-19 14:54 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (30.14 KB, patch)
2020-11-19 15:40 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (30.13 KB, patch)
2020-11-19 15:45 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (30.10 KB, patch)
2020-11-19 17:03 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2020-11-19 14:54:23 PST
Created attachment 414623 [details] Patch
Ada Chan
Comment 2 2020-11-19 15:40:34 PST
Created attachment 414627 [details] Patch
Ada Chan
Comment 3 2020-11-19 15:45:05 PST
Created attachment 414629 [details] Patch
Tim Horton
Comment 4 2020-11-19 15:53:57 PST
Comment on attachment 414629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414629&action=review > Source/WebCore/Modules/webxr/WebXRRigidTransform.h:41 > + WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT); Are these for WebKit's use, or just WebCoreTestSupport? If the latter, you can WEBCORE_TESTSUPPORT_EXPORT > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:20 > +#if ENABLE(WEBXR) && USE_OPENXR should be USE(OPENXR), not USE_OPENXR. Ditto in a bunch of places.
Tim Horton
Comment 5 2020-11-19 16:47:06 PST
(In reply to Tim Horton from comment #4) > Comment on attachment 414629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414629&action=review > > > Source/WebCore/Modules/webxr/WebXRRigidTransform.h:41 > > + WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT); > > Are these for WebKit's use, or just WebCoreTestSupport? If the latter, you > can WEBCORE_TESTSUPPORT_EXPORT /nevermind/! That is not the macro I thought it was.
Ada Chan
Comment 6 2020-11-19 17:03:26 PST
Created attachment 414642 [details] Patch
EWS
Comment 7 2020-11-19 20:33:08 PST
Committed r270067: <https://trac.webkit.org/changeset/270067> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414642 [details].
Note You need to log in before you can comment on or make changes to this bug.