Bug 219165

Summary: Regression(r267865) Geolocation API's error callback should be nullable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217162    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-11-19 09:06:05 PST 
Geolocation API's error callback should be nullable. The callback is nullable in both Firefox and Chrome and there is at least one WPT test that fails unless the error callback is nullable.
The specification does not have this parameter as nullable. However, it is particularly risky to be the only engine matching the specification here, especially considering that we used to match other browser engines.
Comment 1 Chris Dumez 2020-11-19 09:17:52 PST 
Created attachment 414590 [details]
Patch
Comment 2 Geoffrey Garen 2020-11-19 09:41:15 PST 
Comment on attachment 414590 [details]
Patch

r=me
Comment 3 EWS 2020-11-19 13:07:10 PST 
Committed r270048: <https://trac.webkit.org/changeset/270048>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414590 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-19 13:08:17 PST 
<rdar://problem/71598706>
Comment 5 Sam Weinig 2020-11-20 09:37:05 PST 
Did you file a bug on the spec?
Comment 6 Chris Dumez 2020-11-20 10:09:15 PST 
(In reply to Sam Weinig from comment #5)
> Did you file a bug on the spec?

Now yes: https://github.com/w3c/geolocation-api/issues/61
Comment 7 Sam Weinig 2020-11-20 14:42:34 PST 
(In reply to Chris Dumez from comment #6)
> (In reply to Sam Weinig from comment #5)
> > Did you file a bug on the spec?
> 
> Now yes: https://github.com/w3c/geolocation-api/issues/61

Thanks!