Bug 219138

Summary:

[WTF] Fix a condition to check if statvfs() succeeds in getVolumeFreeSpace()

Product:

WebKit

Reporter:

Yousuke Kimoto <Yousuke.Kimoto>

Component:

Web Template Framework

Assignee:

Yousuke Kimoto <Yousuke.Kimoto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch to fix the condition.	none

Description Yousuke Kimoto 2020-11-18 18:04:57 PST

statvfs() returns Zero on success, and -1 is returned on error.

But getVolumeFreeSpace() of FileSystemPOSIX.cpp treats a non Zero value as success case. The condition is wrong.

Comment 1 Yousuke Kimoto 2020-11-18 18:11:47 PST

Created attachment 414524 [details]
Patch to fix the condition.

Comment 2 EWS 2020-11-18 20:00:41 PST

Committed r270013: <https://trac.webkit.org/changeset/270013>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414524 [details].

Comment 3 Radar WebKit Bug Importer 2020-11-18 20:01:46 PST

<rdar://problem/71569072>