| Summary: | [iOS][FCR] Add new look for meter element | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 219046 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Aditya Keerthi
2020-11-18 11:51:58 PST
Created attachment 414465 [details]
Patch
Patch will apply once https://bugs.webkit.org/show_bug.cgi?id=219046 has landed. Comment on attachment 414465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414465&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2092 > + auto* element = renderMeter.meterElement(); Nit - I /think/ we prefer RefPtr over raw pointers like this in new code (i.e. auto element = makeRefPtr(renderMeter.meterElement());) Created attachment 414949 [details]
Patch for landing
Committed r270207: <https://trac.webkit.org/changeset/270207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414949 [details]. |