| Summary: | [macOS] The WebContent sandbox does not apply for open source builds | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Per Arne Vollan
2020-11-16 07:09:37 PST
Created attachment 414232 [details]
Patch
Comment on attachment 414232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414232&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:115 > +#if USE(APPLE_INTERNAL_SDK) && __MAC_OS_X_VERSION_MIN_REQUIRED > 110000 It may be nicer to add and use HAVE(SANDBOX_MESSAGE_FILTERING) instead of version checks everywhere. (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 414232 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414232&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:115 > > +#if USE(APPLE_INTERNAL_SDK) && __MAC_OS_X_VERSION_MIN_REQUIRED > 110000 > > It may be nicer to add and use HAVE(SANDBOX_MESSAGE_FILTERING) instead of > version checks everywhere. Ah, good point, will fix. Thanks for reviewing! Created attachment 414247 [details]
Patch
Created attachment 414250 [details]
Patch
Committed r269867: <https://trac.webkit.org/changeset/269867> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414250 [details]. |