| Summary: | TextEncoderStreamEncoder should not be exposed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | DOM | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, sam, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-11-15 04:12:37 PST
Created attachment 414162 [details]
Patch
Created attachment 414168 [details]
Patch
Comment on attachment 414168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414168&action=review r=me > Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:206 > + if ((jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()->isSecureContext() && TestEnabledForContext::enabledForContext(*jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()))) { Looks like we need to remove this brace. > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:248 > + if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) { Ditto about the brace. > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:251 > + if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) { Ditto. > Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:717 > + if (RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) { Ditto. Created attachment 414197 [details]
Patch for landing
Committed r269847: <https://trac.webkit.org/changeset/269847> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414197 [details]. |