Bug 218929

Summary: WebAudio tests may give slightly different outputs on different platforms
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore JavaScriptAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-11-13 16:41:18 PST
WebAudio tests may give slightly different outputs on different platforms, causing what looks like flakiness. This is due to the "(contains X different values)" because X may differ from one platform to another (usually +/- 1).
Attachments
Patch (344.53 KB, patch)
2020-11-13 16:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (344.55 KB, patch)
2020-11-13 18:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-11-13 16:44:22 PST
Created attachment 414108 [details] Patch
Sam Weinig
Comment 2 2020-11-13 17:06:32 PST
Comment on attachment 414108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414108&action=review Are you planning on submitting something to make a similar change upstream as well? > LayoutTests/imported/w3c/ChangeLog:8 > + webaudio_contains_different_values This could use a better description.
Chris Dumez
Comment 3 2020-11-13 18:09:50 PST
Comment on attachment 414108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414108&action=review >> LayoutTests/imported/w3c/ChangeLog:8 >> + webaudio_contains_different_values > > This could use a better description. Oops
Chris Dumez
Comment 4 2020-11-13 18:11:34 PST
Created attachment 414113 [details] Patch
Geoffrey Garen
Comment 5 2020-11-13 19:44:28 PST
Comment on attachment 414113 [details] Patch r=me
EWS
Comment 6 2020-11-16 08:41:20 PST
Committed r269853: <https://trac.webkit.org/changeset/269853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414113 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-16 08:42:24 PST
<rdar://problem/71441476>
Note You need to log in before you can comment on or make changes to this bug.