| Summary: | Bring up Big Sur Builders and Testers | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Matt Lewis <jlewis3> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, jbedard, ryanhaddad, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=219039 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Matt Lewis
2020-11-13 11:41:26 PST
Created attachment 414086 [details]
Patch
Created attachment 414095 [details]
Patch
Created attachment 414096 [details]
Patch
Created attachment 414100 [details]
Patch
Comment on attachment 414100 [details]
Patch
Patch looks fine. r- due to unit-tests failure. Try to run tests locally as well.
Created attachment 414105 [details]
Patch
Comment on attachment 414105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414105&action=review > Tools/CISupport/build-webkit-org/config.json:130 > + "workernames": ["bot1020","bot1021"] Nit: missing space after comma. > Tools/CISupport/build-webkit-org/config.json:135 > + "workernames": ["bot1022","bot1023"] Nit: missing space after comma. > Tools/CISupport/build-webkit-org/config.json:150 > + "workernames": ["bot1026","bot1027"] Nit: missing space after comma. Created attachment 414270 [details]
Patch for landing
Committed r269874: <https://trac.webkit.org/changeset/269874> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414270 [details]. Comment on attachment 414270 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=414270&action=review > Tools/CISupport/build-webkit-org/config.json:128 > + "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"], architecture on builder and tester doesn't match. builder have: "["x86_64", "arm64"]", while tester have: ["x86_64"]. This mismatch is causing tester not to find the uploaded archive. e.g.: in https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/steps/transfer-to-s3/logs/stdio builder uploaded at: https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269887.zip while in https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/steps/download-built-product/logs/stdio tester is trying to download from: https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64-release/269887.zip (In reply to Aakash Jain from comment #11) > Comment on attachment 414270 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414270&action=review > > > Tools/CISupport/build-webkit-org/config.json:128 > > + "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"], > > architecture on builder and tester doesn't match. builder have: "["x86_64", > "arm64"]", while tester have: ["x86_64"]. > > This mismatch is causing tester not to find the uploaded archive. > e.g.: in > https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/ > steps/transfer-to-s3/logs/stdio builder uploaded at: > https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 > arm64-release/269887.zip > > while in > https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/ > steps/download-built-product/logs/stdio tester is trying to download from: > https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64- > release/269887.zip I guess the tester should declare that it wants universal binaries? That feels wrong though...results uploading knows the difference, so we aren't passing architecture through to run-webkit-tests. |