| Summary: | [LFC][Integration] Use the physical size when setting the pre-computed width/height on ReplacedBox | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-11-13 10:36:32 PST
Created attachment 414061 [details]
Patch
Comment on attachment 414061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414061&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126 > + updateReplacedDimensions(inlineBlock) Might be nicer to have a private shared function (updateReplacedOrInlineBlockDimensions or similar) (In reply to Antti Koivisto from comment #2) > Comment on attachment 414061 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414061&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126 > > + updateReplacedDimensions(inlineBlock) > > Might be nicer to have a private shared function > (updateReplacedOrInlineBlockDimensions or similar) good point! Created attachment 414065 [details]
Patch
Committed r269818: <https://trac.webkit.org/changeset/269818> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414065 [details]. |