Bug 218908

Summary:

[Mac] Create a MediaToolbox format reader plug-in for WebM

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, benjamin, calvaris, cdumez, cgarcia, cmarcelo, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, tsavell, vjaquez, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

227382

Bug Blocks:

Attachments:

Description	Flags
WIP	none
WIP	ews-feeder: commit-queue-
WIP	none
More WIP: add a runtime flag	none
More WIP: SampleCursor improvements	none
Another WIP	none
Another WIP	none
Another WIP	ews-feeder: commit-queue-
More WIP: Implement SampleCursor::copySampleLocation	none
More WIP: cleanup and refactor SourceBufferParserWebM	none
Part 1: Install a format reader plug-in in WebKit.framework/PlugIns	eric.carlson: review+
Part 1: Create a format reader plug-in for WebM	none
Part 2: Register the format reader plug-in for WebM content types	eric.carlson: review+, ews-feeder: commit-queue-
Part 2: Register the format reader plug-in for WebM content types	none
Part 2: Register the format reader plug-in for WebM content types	none
Part 2: Register the format reader plug-in for WebM content types	none
Part 2: Register the format reader plug-in for WebM content types	none
Part 3: Abstract SourceBufferParser segments	none
Part 2: Register the format reader plug-in for WebM content types	ews-feeder: commit-queue-
Part 3: Abstract SourceBufferParser segments	aestes: commit-queue-
Part 3: Abstract SourceBufferParser segments	none
Part 4: Implement and test the format reader	none
Part 4: Implement and test the format reader	none
Part 4: Implement and test the format reader	none
Part 4: Implement and test the format reader	none
Part 4: Implement and test the format reader	ews-feeder: commit-queue-
Part 4: Implement and test the format reader	ews-feeder: commit-queue-
Part 4: Implement and test the format reader	none
Part 4: Implement and test the format reader	none
Patch for landing	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	none
Patch for landing	none

Description Andy Estes 2020-11-13 09:04:03 PST

[Mac] Create a MediaToolbox format reader plug-in for WebM

Comment 1 Andy Estes 2020-11-13 09:04:35 PST Comment hidden (obsolete)

rdar://58128802

Comment 2 Andy Estes 2020-11-13 09:12:21 PST

rdar://71373264

Comment 3 Andy Estes 2020-11-15 14:48:08 PST Comment hidden (obsolete)

Created attachment 414179 [details]
WIP

Comment 4 Andy Estes 2020-11-15 14:52:09 PST Comment hidden (obsolete)

Work in(In reply to Andy Estes from comment #3)
> Created attachment 414179 [details]
> WIP

Still plenty of cleanup left to do, notably:

1. The plug-in should move from WebCore to WebKit since it must link the WebKit umbrella framework on Mac.
2. The WebContent process needs to register the plug-in at runtime (although this is testable now in a stand-alone test executable).
3. Needs a runtime flag.

Comment 5 Eric Carlson 2020-11-17 13:02:21 PST Comment hidden (obsolete)

Created attachment 414376 [details]
WIP

Comment 6 Eric Carlson 2020-11-17 13:30:56 PST Comment hidden (obsolete)

Created attachment 414381 [details]
WIP

Comment 7 Eric Carlson 2020-11-17 15:34:09 PST Comment hidden (obsolete)

Created attachment 414391 [details]
More WIP: add a runtime flag

Comment 8 Andy Estes 2020-12-01 13:42:46 PST Comment hidden (obsolete)

Created attachment 415157 [details]
More WIP: SampleCursor improvements

Comment 9 Eric Carlson 2020-12-08 16:13:34 PST Comment hidden (obsolete)

Created attachment 415688 [details]
Another WIP

Comment 10 Eric Carlson 2020-12-08 17:35:56 PST Comment hidden (obsolete)

Created attachment 415695 [details]
Another WIP

Comment 11 Eric Carlson 2020-12-09 00:12:31 PST Comment hidden (obsolete)

Created attachment 415725 [details]
Another WIP

Comment 12 Andy Estes 2020-12-09 03:08:05 PST Comment hidden (obsolete)

Created attachment 415734 [details]
More WIP: Implement SampleCursor::copySampleLocation

Comment 13 Eric Carlson 2020-12-09 17:31:14 PST Comment hidden (obsolete)

Created attachment 415814 [details]
More WIP: cleanup and refactor SourceBufferParserWebM

Comment 14 Andy Estes 2020-12-09 17:34:55 PST Comment hidden (obsolete)

Created attachment 415815 [details]
Part 1: Install a format reader plug-in in WebKit.framework/PlugIns

Comment 15 Andy Estes 2020-12-10 17:19:53 PST Comment hidden (obsolete)

Created attachment 415949 [details]
Part 1: Create a format reader plug-in for WebM

Comment 16 Andy Estes 2020-12-10 17:37:16 PST Comment hidden (obsolete)

Created attachment 415952 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 17 Andy Estes 2020-12-10 17:46:41 PST Comment hidden (obsolete)

Created attachment 415953 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 18 Andy Estes 2020-12-10 18:32:09 PST Comment hidden (obsolete)

Created attachment 415956 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 19 Andy Estes 2020-12-10 18:36:20 PST Comment hidden (obsolete)

Created attachment 415957 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 20 Andy Estes 2020-12-10 19:39:44 PST Comment hidden (obsolete)

Created attachment 415961 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 21 EWS 2020-12-10 21:21:51 PST

Committed r270666: <https://trac.webkit.org/changeset/270666>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415949 [details].

Comment 22 Andy Estes 2020-12-10 23:18:37 PST

Reopening to attach new patch.

Comment 23 Andy Estes 2020-12-10 23:18:38 PST Comment hidden (obsolete)

Created attachment 415972 [details]
Part 3: Abstract SourceBufferParser segments

Comment 24 EWS 2020-12-11 15:19:33 PST Comment hidden (obsolete)

Patch 415961 does not build

Comment 25 Andy Estes 2020-12-11 15:34:05 PST Comment hidden (obsolete)

Created attachment 416054 [details]
Part 2: Register the format reader plug-in for WebM content types

Comment 26 Andy Estes 2020-12-11 15:38:33 PST Comment hidden (obsolete)

Created attachment 416056 [details]
Part 3: Abstract SourceBufferParser segments

Comment 27 EWS 2020-12-11 15:39:30 PST Comment hidden (obsolete)

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Comment 28 Andy Estes 2020-12-11 15:39:47 PST Comment hidden (obsolete)

Created attachment 416057 [details]
Part 3: Abstract SourceBufferParser segments

Comment 29 EWS 2020-12-11 16:08:13 PST

Committed r270717: <https://trac.webkit.org/changeset/270717>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416057 [details].

Comment 30 Andy Estes 2020-12-11 17:44:01 PST

Reopening to attach new patch.

Comment 31 EWS 2020-12-11 18:05:47 PST Comment hidden (obsolete)

Found 4 new test failures: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback.html, media/media-can-play-webm.html

Comment 32 Andy Estes 2020-12-11 20:32:24 PST Comment hidden (obsolete)

Created attachment 416085 [details]
Part 4: Implement and test the format reader

Comment 33 Andy Estes 2020-12-11 22:46:09 PST Comment hidden (obsolete)

Created attachment 416094 [details]
Part 4: Implement and test the format reader

Comment 34 Andy Estes 2020-12-12 06:47:40 PST Comment hidden (obsolete)

Created attachment 416095 [details]
Part 4: Implement and test the format reader

Comment 35 Andy Estes 2020-12-12 09:21:42 PST Comment hidden (obsolete)

Created attachment 416098 [details]
Part 4: Implement and test the format reader

Comment 36 Andy Estes 2020-12-12 11:32:08 PST Comment hidden (obsolete)

Created attachment 416102 [details]
Part 4: Implement and test the format reader

Comment 37 Andy Estes 2020-12-12 11:54:05 PST Comment hidden (obsolete)

Created attachment 416103 [details]
Part 4: Implement and test the format reader

Comment 38 Andy Estes 2020-12-12 12:02:04 PST Comment hidden (obsolete)

Created attachment 416104 [details]
Part 4: Implement and test the format reader

Comment 39 Andy Estes 2020-12-12 13:19:01 PST Comment hidden (obsolete)

Created attachment 416106 [details]
Part 4: Implement and test the format reader

Comment 40 Andy Estes 2020-12-12 21:48:05 PST Comment hidden (obsolete)

Created attachment 416113 [details]
Patch for landing

Comment 41 Andy Estes 2020-12-13 10:50:47 PST Comment hidden (obsolete)

Created attachment 416123 [details]
Patch for landing

Comment 42 Andy Estes 2020-12-13 13:36:16 PST Comment hidden (obsolete)

Created attachment 416125 [details]
Patch for landing

Comment 43 Andy Estes 2020-12-13 16:31:48 PST Comment hidden (obsolete)

Created attachment 416128 [details]
Patch for landing

Comment 44 Andy Estes 2020-12-13 18:17:29 PST Comment hidden (obsolete)

Created attachment 416130 [details]
Patch for landing

Comment 45 Andy Estes 2020-12-13 18:44:28 PST

Created attachment 416131 [details]
Patch for landing

Comment 46 EWS 2020-12-13 19:39:27 PST

Committed r270758: <https://trac.webkit.org/changeset/270758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416131 [details].

Comment 47 Andy Estes 2020-12-13 20:40:22 PST

Fixed the build in r270760: <https://trac.webkit.org/changeset/270760>

Comment 48 Andy Estes 2020-12-13 21:20:28 PST

Fixed the build in r270761: <https://trac.webkit.org/changeset/270761>

Comment 49 Truitt Savell 2020-12-22 14:21:54 PST

This caused an Internal testing failure tracked in: rdar://72600426