| Summary: | Support more properties on ::marker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
| Component: | CSS | Assignee: | Antoine Quint <graouts> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=218897 https://bugs.webkit.org/show_bug.cgi?id=218995 |
||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 218792 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antoine Quint
2020-11-13 02:28:43 PST
Created attachment 414020 [details]
Patch
Comment on attachment 414020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414020&action=review > Source/WebCore/css/html.css:305 > ::marker { You could add a comment here saying that the ::before/::after are handled by computeMarkerStyle. > Source/WebCore/rendering/RenderListItem.cpp:75 > RenderStyle parentStyle = RenderStyle::clone(style()); > auto fontDescription = style().fontDescription(); > - fontDescription.setVariantNumericSpacing(FontVariantNumericSpacing::TabularNumbers); > + if (is<PseudoElement>(element())) > + fontDescription.setVariantNumericSpacing(FontVariantNumericSpacing::TabularNumbers); > parentStyle.setFontDescription(WTFMove(fontDescription)); > parentStyle.fontCascade().update(&document().fontSelector()); > if (auto markerStyle = getCachedPseudoStyle(PseudoId::Marker, &parentStyle)) This seems overly hackish. If I understand correctly this function should have two branches. 1) The regular one that just does getCachedPseudoStyle(PseudoId::Marker, &style()) and nothing else a 2) A hack branch for is<PseudoElement> case where it initializes all of ::marker UA style (including unicode-bidi and white-space). It doesn't need to call getCachedPseudoStyle since it won't work. Created attachment 414033 [details]
Patch
Committed r269774: <https://trac.webkit.org/changeset/269774> |