Bug 218889

Summary: [LFC][Integration] Enable inline-block
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, ggaren, glenn, jbedard, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220638
Bug Depends on: 218901, 219205    
Bug Blocks:    
Attachments:
Description Flags
for bots
ews-feeder: commit-queue-
for bots
none
for bots
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2020-11-13 00:57:23 PST 
display: inline-block
Comment 1 Antti Koivisto 2020-11-13 00:59:03 PST 
Created attachment 414009 [details]
for bots
Comment 2 Antti Koivisto 2020-11-13 04:25:35 PST 
Created attachment 414031 [details]
for bots
Comment 3 Antti Koivisto 2020-11-13 04:28:06 PST 
Created attachment 414032 [details]
for bots
Comment 4 zalan 2020-11-13 09:34:48 PST 
Created attachment 414053 [details]
Patch
Comment 5 zalan 2020-11-15 20:55:22 PST 
Created attachment 414191 [details]
Patch
Comment 6 zalan 2020-11-17 10:28:24 PST 
Created attachment 414351 [details]
Patch
Comment 7 zalan 2020-11-17 20:34:20 PST 
Created attachment 414404 [details]
Patch
Comment 8 zalan 2020-11-18 15:55:33 PST 
Created attachment 414505 [details]
Patch
Comment 9 zalan 2020-11-19 13:43:20 PST 
Created attachment 414616 [details]
Patch
Comment 10 zalan 2020-11-19 14:29:44 PST 
Created attachment 414620 [details]
Patch
Comment 11 zalan 2020-11-19 16:40:46 PST 
Created attachment 414638 [details]
Patch
Comment 12 zalan 2020-11-19 20:33:16 PST 
Created attachment 414647 [details]
Patch
Comment 13 EWS 2020-11-19 22:00:06 PST 
Committed r270070: <https://trac.webkit.org/changeset/270070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414647 [details].
Comment 14 Radar WebKit Bug Importer 2020-11-19 22:01:21 PST 
<rdar://problem/71615879>
Comment 15 zalan 2020-11-20 05:25:02 PST 
Reverted r270070 for reason:

broke an API test

Committed r270108: <https://trac.webkit.org/changeset/270108>
Comment 16 zalan 2020-11-20 10:40:36 PST 
Committed r270123: <https://trac.webkit.org/changeset/270123>
Comment 17 Geoffrey Garen 2020-12-03 16:31:28 PST 
Looks like this was a 9% - 11% regression on StyleBench.

You can see the initial regression when the patch landed, then a return to normal, then another regression when the patch landed a second time.

The bot is a little confusing because the runloop regression landed immediately after. But that regression has been rolled out, and this one remains visible on the bot.

https://perf.webkit.org/v3/#/charts?since=1600721032751&zoom=(1605422135834.8188-1606923328416.2063)&paneList=((21-1649-(1605785343399.1538-1605903635771.0242)-null-(5-2.5-500))-(21-1006-null-null-(5-2.5-500))-(21-1019-null-null-(5-2.5-500))-(21-1032)-(21-1045-null-null-(5-2.5-500))-(21-1407-null-null-(5-2.5-500))-(21-1648-null-null-(5-2.5-500))-(21-1974-null-null-(5-2.5-500)))