| Summary: | REGRESSION(r269701): inspector/console/webcore-logging.html is crashing | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=218730 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
BJ Burg
2020-11-11 19:56:40 PST
Created attachment 413903 [details]
Stack trace of ASSERT
Patch forthcoming. Analysis: Test.html finishes loading. Our load event listener calls InspectorFrontendHost::loaded() which makes the inspector focus, which makes the webpage window unfocus and resign first responder. This causes style recalc, and we have sync instrumentation underneath it (this should really be more async btw). The instrumentation generates an event to be dispatched to the frontend. The dispatcher hasn't been told that the window is loaded yet under InspectorFrontendHost::frontendLoaded. It's not safe to eval scripts due to the sync style recalc upthread, so the dispatcher suspends and tries again on another run loop turn. (In reply to Brian Burg from comment #4) > Analysis: > > Test.html finishes loading. Our load event listener calls > InspectorFrontendHost::loaded() which makes the inspector focus, which > makes the webpage window unfocus and resign first responder. This causes > style recalc, and we have sync instrumentation underneath it (this should > really be more async btw). The instrumentation generates an event to be > dispatched to the frontend. The dispatcher hasn't been told that the window > is loaded yet under InspectorFrontendHost::frontendLoaded. It's not safe to > eval scripts due to the sync style recalc upthread, so the dispatcher > suspends and tries again on another run loop turn. And the crash is due to an ASSERT(m_frontendLoaded) failing. Created attachment 413906 [details]
Speculative fix
Comment on attachment 413906 [details]
Speculative fix
rs=me
Should we also guard the `evaluateQueuedExpressions()` call inside `InspectorFrontendAPIDispatcher::unsuspend` behind an `if (m_frontendLoaded)`?
Created attachment 413957 [details]
Patch v1.1
Newest patch adds a guard in suspend() per Devin's review comment.
(In reply to Brian Burg from comment #8) > Created attachment 413957 [details] > Patch v1.1 > > Newest patch adds a guard in suspend() per Devin's review comment. Typo: unsuspend(), not suspend() Committed r269806: <https://trac.webkit.org/changeset/269806> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413957 [details]. |