Bug 218802

Summary: [build.webkit.org] Update CheckOutSource step for new buildbot
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-11-11 06:39:29 PST
We are planning to upgrade build.webkit.org to latest Buildbot. The base class (SVN) used by CheckOutSource has been moved and modified in new Buildbot. We should update the step accordingly.
Attachments
Patch (2.42 KB, patch)
2020-11-11 06:42 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2020-11-11 12:19 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-11-11 06:42:23 PST
Created attachment 413816 [details] Patch
Jonathan Bedard
Comment 2 2020-11-11 09:09:10 PST
Comment on attachment 413816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413816&action=review > Tools/CISupport/build-webkit-org/steps.py:122 > + SVN.__init__(self, **kwargs) Is there a reason we aren't using super?
Aakash Jain
Comment 3 2020-11-11 12:19:33 PST
Created attachment 413851 [details] Patch
Aakash Jain
Comment 4 2020-11-11 12:20:11 PST
(In reply to Jonathan Bedard from comment #2) > Is there a reason we aren't using super? Updated patch uses super.
EWS
Comment 5 2020-11-11 12:57:08 PST
Committed r269699: <https://trac.webkit.org/changeset/269699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413851 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-11 12:58:21 PST
<rdar://problem/71295484>
Aakash Jain
Comment 7 2020-11-12 05:13:52 PST
(In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #2) > > Is there a reason we aren't using super? > Updated patch uses super. Actually unit-test (and buildbot checkconfig) on old buildbot/python fails when using super on this class (old-style class) with following error (e.g.: https://ews-build.webkit.org/#/builders/20/builds/34537). File "steps.py", line 145, in __init__ super(CheckOutSource, self).__init__(**kwargs) TypeError: super() argument 1 must be type, not classobj This is because this SVN class in old buildbot is old-style class. See: https://stackoverflow.com/questions/1713038/super-fails-with-error-typeerror-argument-1-must-be-type-not-classobj-when
Aakash Jain
Comment 8 2020-11-12 05:18:35 PST
Committed r269731: <https://trac.webkit.org/changeset/269731>
Note You need to log in before you can comment on or make changes to this bug.