Bug 218750

Summary: Add infrastructure for WebRTC transforms
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218790    
Bug Blocks: 218751    
Attachments:
Description Flags
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description youenn fablet 2020-11-10 07:15:20 PST 
Add infrastructure for WebRTC transforms
Comment 1 youenn fablet 2020-11-11 00:23:44 PST 
Created attachment 413790 [details]
WIP
Comment 2 youenn fablet 2020-11-11 00:33:38 PST 
Created attachment 413793 [details]
WIP
Comment 3 Eric Carlson 2020-11-12 10:58:38 PST 
Comment on attachment 413793 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=413793&action=review

> Source/WebCore/Modules/mediastream/RTCRtpReceiverWithTransform.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

s/2013/2020/

> Source/WebCore/Modules/mediastream/RTCRtpSenderWithTransform.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpTransform.cpp:29
> +/*
> + * Copyright (C) 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies).
> + * Copyright (C) 2017 Apple Inc. All rights reserved.
> + *

Is this necessary?
Comment 4 youenn fablet 2020-11-12 11:19:06 PST 
Created attachment 413955 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2020-11-12 11:34:29 PST 
<rdar://problem/71335495>
Comment 6 youenn fablet 2020-11-12 11:43:34 PST 
Created attachment 413959 [details]
Patch
Comment 7 youenn fablet 2020-11-12 12:11:19 PST 
Created attachment 413963 [details]
Patch
Comment 8 youenn fablet 2020-11-12 12:22:17 PST 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 413793 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413793&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCRtpReceiverWithTransform.h:2
> > + * Copyright (C) 2013 Apple Inc. All rights reserved.
> 
> s/2013/2020/
> 
> > Source/WebCore/Modules/mediastream/RTCRtpSenderWithTransform.h:2
> > + * Copyright (C) 2013 Apple Inc. All rights reserved.
> 
> Ditto
> 
> > Source/WebCore/Modules/mediastream/RTCRtpTransform.cpp:29
> > +/*
> > + * Copyright (C) 2012 Google Inc. All rights reserved.
> > + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies).
> > + * Copyright (C) 2017 Apple Inc. All rights reserved.
> > + *
> 
> Is this necessary?

Nope!
Fixed now.
Comment 9 EWS 2020-11-12 23:20:45 PST 
Committed r269764: <https://trac.webkit.org/changeset/269764>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413963 [details].