Bug 218741

Summary: [Web Animations] KeyframeEffect.pseudoElement does not return a valid string when targeting ::marker or ::first-letter
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2020-11-10 01:14:11 PST
[Web Animations] :KeyframeEffect.pseudoElement does not return a valid string when targeting ::marker or ::first-letter
Attachments
Patch (9.56 KB, patch)
2020-11-10 01:17 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-10 01:14:57 PST
<rdar://problem/71229846>
Antoine Quint
Comment 2 2020-11-10 01:17:10 PST
Created attachment 413677 [details] Patch
Antoine Quint
Comment 3 2020-11-10 01:17:15 PST
<rdar://problem/71229846>
Dean Jackson
Comment 4 2020-11-10 01:25:35 PST
Comment on attachment 413677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413677&action=review > Source/WebCore/ChangeLog:11 > + We used to use PseudoElement::pseudoElementNameForEvents() to go from PseudoId to a String, but PseudoElement > + only knows about ::before and ::after and not about valid pseudo-elements. We remove that method and create an > + equivalent in WebAnimationUtilities that knows about all public pseudo-elements. Why not fix pseudoElementNameForEvents to handle all pseudo elements? > Source/WebCore/animation/WebAnimationUtilities.cpp:182 > +String pseudoIdAsString(PseudoId pseudoId) > +{ Yeah, I think this should stay on PseudoElement. If you were going to update the list, it's where you would look. Not inside WebAnimationUtilities.
Antoine Quint
Comment 5 2020-11-10 01:31:28 PST
Actually, we want to move away from PseudoElement which are only ever created for ::before and ::after pseudo-elements. We've moved to using the Styleable struct throughout the animation code so that we rely on PseudoElement as little as possible. We only ever need to convert from a PseudoId to a String for animations, so I believe this is the right place.
EWS
Comment 6 2020-11-10 03:36:13 PST
Committed r269623: <https://trac.webkit.org/changeset/269623> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413677 [details].
Note You need to log in before you can comment on or make changes to this bug.