Bug 218738

Summary: Use GraphicsContext instead of CGContext in RemoteLayerBackingStore
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Tim Horton 2020-11-09 21:09:23 PST 
Use GraphicsContext instead of CGContext in RemoteLayerBackingStore
Comment 1 Tim Horton 2020-11-09 21:09:43 PST 
Created attachment 413660 [details]
Patch
Comment 2 Tim Horton 2020-11-09 22:58:18 PST 
Created attachment 413668 [details]
Patch
Comment 3 Wenson Hsieh 2020-11-09 23:07:13 PST 
Comment on attachment 413668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413668&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:272
> +void RemoteLayerBackingStore::drawInContext(WebCore::GraphicsContext& context, RefPtr<WebCore::NativeImage> backImage)

Nit - I think we generally RefPtr<>&& these, so that we can use move semantics from the call site if possible.
Comment 4 Tim Horton 2020-11-09 23:19:09 PST 
Created attachment 413670 [details]
Patch
Comment 5 Tim Horton 2020-11-09 23:22:00 PST 
Created attachment 413671 [details]
Patch
Comment 6 Tim Horton 2020-11-10 16:09:13 PST 
Created attachment 413755 [details]
Patch
Comment 7 EWS 2020-11-10 16:47:17 PST 
Committed r269664: <https://trac.webkit.org/changeset/269664>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413755 [details].
Comment 8 Radar WebKit Bug Importer 2020-11-10 16:48:22 PST 
<rdar://problem/71261307>