Bug 218736

Summary:

[LFC Display] A ContainerBox can establish an inline formatting context and have box children

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Simon Fraser (smfr) 2020-11-09 19:31:30 PST

[LFC Display] A ContainerBox can have establish and inline formatting context and have box children

Comment 1 Simon Fraser (smfr) 2020-11-09 19:32:26 PST

Created attachment 413656 [details]
Patch

Comment 2 zalan 2020-11-09 19:34:43 PST

Comment on attachment 413656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413656&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC Display] A ContainerBox can have establish and inline formatting context and have box children

:)

Comment 3 Radar WebKit Bug Importer 2020-11-16 19:32:15 PST

<rdar://problem/71470058>

Comment 4 Simon Fraser (smfr) 2020-11-27 09:32:19 PST

Created attachment 414951 [details]
Patch

Comment 5 Simon Fraser (smfr) 2020-11-27 09:46:58 PST

https://trac.webkit.org/r270198

Comment 6 Sam Weinig 2020-11-28 11:51:09 PST

Comment on attachment 414951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414951&action=review

> Source/WebCore/display/DisplayTreeBuilder.cpp:157
> +        switch (boxInclusion) {
> +        case DescendantBoxInclusion::AllBoxes: return true;
> +        case DescendantBoxInclusion::OutOfFlowOnly: return !box.isInFlow();
> +        }

Not a fan of this one line style. Can you move the returns to their own line.

> Source/WebCore/display/DisplayTreeBuilder.cpp:158
> +        return false;

There can probably a be an ASSERT_NOT_REACHED here for good measure.

Comment 7 Sam Weinig 2020-11-28 11:51:23 PST

Should this still be up for review?