| Summary: | Unexpose obsolete HTMLAppletElement interface | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | aboxhall, achristensen, annulen, apinheiro, berto, cfleizach, cgarcia, changseok, darin, d, dmazzoni, esprehn+autocc, ews-watchlist, ggaren, glenn, gustavo, gyuyoung.kim, japhet, jcraig, jdiggs, kondapallykalyan, mifenton, pdr, ryuan.choi, samuel_white, sam, sergio, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Chris Dumez
2020-11-06 17:08:14 PST
Created attachment 413499 [details]
WIP Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 413591 [details]
WIP Patch
Created attachment 413595 [details]
WIP Patch
Created attachment 413597 [details]
WIP Patch
Created attachment 413603 [details]
WIP Patch
Created attachment 413615 [details]
Patch
Comment on attachment 413615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review I suspect there is a bit more that can be removed afterwards. > Source/WebCore/html/HTMLPlugInImageElement.h:32 > +// Base class for HTMLEmbedElement, and HTMLObjectElement. Should remove the "," here. > Source/WebCore/html/HTMLTagNames.in:11 > +applet interfaceName=HTMLUnknownElement Why do we need this? What is the benefit over just removing the tag name entirely instead? > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElementPrivate.h:20 > #ifndef WebKitDOMHTMLAppletElementPrivate_h Seems like someone with enough knowledge of how things are used could remove this entire header instead. > Source/WebKitLegacy/mac/DOM/DOMHTMLAppletElement.mm:30 > #import <WebCore/HTMLNames.h> Can remove most of these includes, maybe all. > LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt:35 > APPLET also has: Should we change the test to remove this? Comment on attachment 413615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review >> Source/WebCore/html/HTMLTagNames.in:11 >> +applet interfaceName=HTMLUnknownElement > > Why do we need this? What is the benefit over just removing the tag name entirely instead? I tried what you suggested first but this was causing some WPT tests failures. Support for <applet> has not been removed at HTML parser level. Created attachment 413631 [details]
Patch
Created attachment 413632 [details]
Patch
Relatedly, these files can be removed from the ManualTests folder: accessibility/java-applet.html accessibility/resources/AppletTest.java applet-finish-parsing-children.html applet-param-no-name.html java-string-object-type.html liveconnect-applet-array-parameters.html liveconnect-applet-get-boolean.html liveconnect-security-exception.html resources/DrawMessage.class resources/ArrayParameterTestApplet.class resources/liveconnect-security-exception-popup.html resources/CheckerApplet.java resources/ArrayParameterTestApplet.java resources/TestApplet.class resources/StringTypeTest.class resources/CheckerApplet.class resources/TestApplet.java resources/StringTypeTest.java Created attachment 413634 [details]
Patch
(In reply to Geoffrey Garen from comment #12) > Relatedly, these files can be removed from the ManualTests folder: > > accessibility/java-applet.html > accessibility/resources/AppletTest.java > applet-finish-parsing-children.html > applet-param-no-name.html > java-string-object-type.html > liveconnect-applet-array-parameters.html > liveconnect-applet-get-boolean.html > liveconnect-security-exception.html > resources/DrawMessage.class > resources/ArrayParameterTestApplet.class > resources/liveconnect-security-exception-popup.html > resources/CheckerApplet.java > resources/ArrayParameterTestApplet.java > resources/TestApplet.class > resources/StringTypeTest.class > resources/CheckerApplet.class > resources/TestApplet.java > resources/StringTypeTest.java Thanks, I dropped these too. I did not even know this folder existed :) Committed r269612: <https://trac.webkit.org/changeset/269612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413634 [details]. *** Bug 157926 has been marked as a duplicate of this bug. *** |