Bug 218654

Summary: REGRESSION(r269503): [GTK][WPE] >200 tests are failing
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, clopez, clord, lmoura, sabouhallawa, sam, simon.fraser, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2020-11-06 03:01:21 PST
More than 200 tests are failing in GTK and WPE since r269503 landed. https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r269503%20(16840)/results.html
Attachments
Patch (2.34 KB, patch)
2020-11-06 04:27 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2020-11-06 05:08 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2020-11-06 08:06 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2020-11-09 01:29 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2020-11-06 04:27:09 PST
Created attachment 413419 [details] Patch
Chris Lord
Comment 2 2020-11-06 05:08:28 PST
Created attachment 413426 [details] Patch
EWS
Comment 3 2020-11-06 05:47:10 PST
Committed r269508: <https://trac.webkit.org/changeset/269508> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413426 [details].
Radar WebKit Bug Importer
Comment 4 2020-11-06 05:48:58 PST
<rdar://problem/71116949>
Chris Lord
Comment 5 2020-11-06 08:03:05 PST
The last patch wasn't quite correct and caused some new test failures in canvas tests. Turns out it was over-complicated, will attach a fix.
Chris Lord
Comment 6 2020-11-06 08:06:35 PST
Created attachment 413433 [details] Patch
Carlos Alberto Lopez Perez
Comment 7 2020-11-06 08:53:14 PST
The patch seems already reviewed. Do you need cq+?
Chris Lord
Comment 8 2020-11-06 08:59:40 PST
(In reply to Carlos Alberto Lopez Perez from comment #7) > The patch seems already reviewed. Do you need cq+? I pre-emptively filled the reviewed by field so I wouldn't have to re-upload, but it isn't reviewed yet. I think it's reasonably inert, but I'd like Zan's approval before cq+.
Lauro Moura
Comment 9 2020-11-08 20:22:10 PST
I've gardened the failures in r269572, separated from other gardening to make it easier to revert. Testing locally, this second fix indeed fixes the issue for the 5 failing tests.
Chris Lord
Comment 10 2020-11-09 01:29:45 PST
Created attachment 413568 [details] Patch
EWS
Comment 11 2020-11-09 02:19:56 PST
Committed r269578: <https://trac.webkit.org/changeset/269578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413568 [details].
Note You need to log in before you can comment on or make changes to this bug.