| Summary: | REGRESSION(r269503): [GTK][WPE] >200 tests are failing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||||
| Component: | New Bugs | Assignee: | Chris Lord <clord> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, clopez, clord, lmoura, sabouhallawa, sam, simon.fraser, webkit-bug-importer, zan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Diego Pino
2020-11-06 03:01:21 PST
Created attachment 413419 [details]
Patch
Created attachment 413426 [details]
Patch
Committed r269508: <https://trac.webkit.org/changeset/269508> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413426 [details]. The last patch wasn't quite correct and caused some new test failures in canvas tests. Turns out it was over-complicated, will attach a fix. Created attachment 413433 [details]
Patch
The patch seems already reviewed. Do you need cq+? (In reply to Carlos Alberto Lopez Perez from comment #7) > The patch seems already reviewed. Do you need cq+? I pre-emptively filled the reviewed by field so I wouldn't have to re-upload, but it isn't reviewed yet. I think it's reasonably inert, but I'd like Zan's approval before cq+. I've gardened the failures in r269572, separated from other gardening to make it easier to revert. Testing locally, this second fix indeed fixes the issue for the 5 failing tests. Created attachment 413568 [details]
Patch
Committed r269578: <https://trac.webkit.org/changeset/269578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413568 [details]. |