Bug 218624

Summary:

Change RELEASE_ASSERT to use branch+crash inside HashTable.h

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mark.lam: review+
patch for landing	none

Description Saam Barati 2020-11-05 10:39:15 PST

...

Comment 1 Saam Barati 2020-11-05 10:42:27 PST

<rdar://problem/70901101>

Comment 2 Saam Barati 2020-11-05 10:56:36 PST

Created attachment 413324 [details]
patch

Comment 3 Mark Lam 2020-11-05 11:02:55 PST

Comment on attachment 413324 [details]
patch

r=me.  Can you introduce a HASH_TABLE_ASSERT macro to encapsulate this instead?  You can #undef it at the end of the file.

Comment 4 Mark Lam 2020-11-05 11:03:28 PST

/HASH_TABLE_ASSERT/HASH_TABLE_RELEASE_ASSERT/

Comment 5 Saam Barati 2020-11-05 11:12:02 PST

Created attachment 413328 [details]
patch for landing

Comment 6 EWS 2020-11-05 15:02:46 PST

Committed r269478: <https://trac.webkit.org/changeset/269478>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413328 [details].