Bug 218611

Summary: Test that skip_validation is effective
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Angelos Oikonomopoulos 2020-11-05 05:22:57 PST
Test that skip_validation is effective
Comment 1 Angelos Oikonomopoulos 2020-11-05 05:24:05 PST
Created attachment 413285 [details]
Patch
Comment 2 Aakash Jain 2020-11-05 05:55:55 PST
Comment on attachment 413285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413285&action=review

looks good

> Tools/CISupport/ews-build/steps_unittest.py:3603
> +        self.setProperty('skip_validation', '1')

Better to pass Boolean here
Comment 3 Angelos Oikonomopoulos 2020-11-05 06:01:11 PST
Created attachment 413288 [details]
Patch
Comment 4 Angelos Oikonomopoulos 2020-11-05 06:02:55 PST
(In reply to Aakash Jain from comment #2)
> Comment on attachment 413285 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413285&action=review
> 
> looks good
> 
> > Tools/CISupport/ews-build/steps_unittest.py:3603
> > +        self.setProperty('skip_validation', '1')
> 
> Better to pass Boolean here

Fixed.
Comment 5 EWS 2020-11-05 06:44:33 PST
Committed r269429: <https://trac.webkit.org/changeset/269429>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413288 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-05 06:45:53 PST
<rdar://problem/71076634>