| Summary: | Store WeakPtr<Frame> instead of Frame* | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, cdumez, cgarcia, changseok, esprehn+autocc, ews-watchlist, glenn, gustavo, gyuyoung.kim, hi, japhet, joepeck, kangil.han, kondapallykalyan, pdr, tsavell, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=218662 https://bugs.webkit.org/show_bug.cgi?id=223838 |
||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-11-04 20:31:00 PST
Created attachment 413244 [details]
Patch
Created attachment 413247 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 413247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413247&action=review > Source/WebCore/bindings/js/WindowProxy.h:53 > + WEBCORE_EXPORT AbstractFrame* frame() const; Why not keeping it inline? Comment on attachment 413247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413247&action=review >> Source/WebCore/bindings/js/WindowProxy.h:53 >> + WEBCORE_EXPORT AbstractFrame* frame() const; > > Why not keeping it inline? That would require including AbstractFrame.h to build successfully. Tools/Scripts/svn-apply failed to apply attachment 413247 [details] to trunk.
Please resolve the conflicts and upload a new patch.
It looks like the changes in https://trac.webkit.org/changeset/269435/webkit broke Mac builds builds: https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/2839 ./loader/FrameLoader.cpp:389:12: error: no viable conversion from returned value of type 'WeakPtr<WebCore::Frame>' to function return type 'WebCore::Frame *' ./loader/FrameLoader.cpp:394:12: error: no viable conversion from returned value of type 'const WeakPtr<WebCore::Frame>' to function return type 'const WebCore::Frame *' |