Bug 218573

Summary: Non-fullscreen page contents visible when rotating device during element fullscreen presentation.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, peng.liu6, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch
none
Patch jer.noble: review?, ews-feeder: commit-queue-

Jer Noble
Reported 2020-11-04 10:51:31 PST
Non-fullscreen page contents visible when rotating device during element fullscreen presentation.
Attachments
Patch (11.34 KB, patch)
2020-11-04 11:13 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.05 KB, patch)
2020-11-05 09:31 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (44.11 KB, patch)
2020-11-09 09:21 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (42.29 KB, patch)
2020-11-10 14:00 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (42.29 KB, patch)
2020-11-11 09:36 PST, Jer Noble 		jer.noble: review?
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-11-04 10:52:57 PST
<rdar://problem/68528772>
Jer Noble
Comment 2 2020-11-04 11:13:20 PST
Created attachment 413186 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-11-04 11:21:33 PST
Comment on attachment 413186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413186&action=review > Source/WebCore/css/fullscreen.css:36 > + background-color: black !important; A background-image could show over this. > LayoutTests/fullscreen/full-screen-ancestor-overflow-layer-dump.html:29 > + setTimeout(() => { Not sure if this will be reliable.
Jer Noble
Comment 4 2020-11-04 13:16:18 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 413186 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413186&action=review > > > Source/WebCore/css/fullscreen.css:36 > > + background-color: black !important; > > A background-image could show over this. That's ok; the image will be clipped. This really is just so the scroll view gets the right background color, and that just consults the :root and body background colors. > > LayoutTests/fullscreen/full-screen-ancestor-overflow-layer-dump.html:29 > > + setTimeout(() => { > > Not sure if this will be reliable. Should be OK; fullscreen/full-screen-layer-dump.html (that this test was cribbed from) has never flaked, as far as I can see.
Jer Noble
Comment 5 2020-11-05 09:31:35 PST
Created attachment 413312 [details] Patch for landing
Jer Noble
Comment 6 2020-11-09 09:21:05 PST
Created attachment 413594 [details] Patch
Jer Noble
Comment 7 2020-11-10 14:00:39 PST
Created attachment 413736 [details] Patch
Jer Noble
Comment 8 2020-11-11 09:36:41 PST
Created attachment 413833 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.